SDWebImage/SDWebImage

SDWebImage: After adding .refreshCached as option, get is being called without request headers `If-None-Match` and `If-Modified-Since`. How to cache those as well from response http headers and send in request http headers?

Open

#3,589 opened on Aug 24, 2023

View on GitHub
 (24 comments) (0 reactions) (0 assignees)Objective-C (5,978 forks)batch import
feature requesthelp wantedusage

Repository metrics

Stars
 (25,648 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Issue Description and Steps

As per my understanding it must be adding http header and we'll get 304 (not modified in response).

Contributor guide

Research direction
Investigate the SDWebImage source code for the refreshCached option and how HTTP headers are managed during cache revalidation. Trace the code path where If None Match and If Modified Since should be set from cached response headers.
Tech stack
objective c
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
XcodeiOS DevelopmentObjective C
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60