SSENSE/vue-carousel

Bug: events are propagating outside of the carousel

Open

#409 opened on Mar 26, 2019

View on GitHub
 (5 comments) (0 reactions) (0 assignees)JavaScript (513 forks)batch import
buggood first issuehelp wanted

Repository metrics

Stars
 (1,705 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Hi,

Firstly, thanks for this very nice component :)

I'd like to have input range inside draggable carousel. But it's impossible to use these inputs because on drag carousel moves to previous / next slide. Can I somehow control when to swipe carousel or not? Disabling drag functionality for carousel is not an option for me, unfortunately.

jsfiddle

Thanks for any help :)

Contributor guide

Research direction
Inspect the carousel's event handling for drag/swipe and determine how to prevent propagation when interacting with input elements. Look at the source code for event listeners on the carousel and input range. Consider using event.stopPropagation() or checking the event target.
Tech stack
javascriptvue
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptVue
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75