SSENSE/vue-carousel

Feature request: Use style classes instead of inline styles

Open

#48 opened on Apr 19, 2017

View on GitHub
 (4 comments) (11 reactions) (0 assignees)JavaScript (513 forks)batch import
featurehelp wanted

Repository metrics

Stars
 (1,705 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

There're a few component options regarding styles such as paginationActiveColor, paginationPadding, etc. Since they are rendered as inline styles, it is hard to override them with CSS classes. It's better to set CSS classed for these elements. What do you think?

Contributor guide

Research direction
Identify all component options that render inline styles and create corresponding CSS class names. Map each style option to a CSS class and refactor the component to use those classes.
Tech stack
javascriptvue
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
VueCSS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70