SSENSE/vue-carousel

Feature Request: add server side rendering (Nuxt.js) to vue-carousel

Open

#81 opened on Aug 29, 2017

View on GitHub
 (37 comments) (7 reactions) (0 assignees)JavaScript (513 forks)batch import
featurehelp wanted

Repository metrics

Stars
 (1,705 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Newbie. I had vue-carousel running great prior to an update, in nuxt I think. Now it simply won't work.

Running vue-carousel locally in component, Terminal: `[Vue warn]: Error in beforeCreate hook: "ReferenceError: document is not defined"

found in

---> at components/CarouselShow.vue <Pages/index.vue> at pages/index.vue at .nuxt/components/nuxt.vue at layouts/default.vue

` And I guess it is in a loop, because Chrome keeps spinning and eventually I get the dialog box "Do you wish to kill process?"

If I run vue-carousel globally I do not get the warning, but my Slides are static and all Slides show up on the page at once.

Help much appreciated.

Contributor guide

Research direction
Check the vue carousel source for client side specific calls (e.g., window, document) and wrap them in client only checks or use Nuxt's client only component. Also look for existing PRs or discussions about SSR support.
Tech stack
javascriptvuenuxt
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
VueNuxtSSR concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45