SaaShup/netbox-docker-plugin

:zap: prevent exec on non running container

Open

#138 opened on Jun 6, 2024

View on GitHub
 (6 comments) (0 reactions) (0 assignees)Python (12 forks)auto 404
V4enhancementgood first issuehelp wanted

Repository metrics

Stars
 (78 stars)
PR merge metrics
 (PR metrics pending)

Description

Netbox version Plugin Version Agent version Docker API Version
4.* 2.* * *

Actual Behavior

It is possible to run exec command on a non running container :

image

Desired Behavior

if the container is not running we should prevent to run exec command on the container :

image

Contributor guide

Research direction
Check the container status (running/not) before handling exec requests. Add a validation that returns an error if container is not running.
Tech stack
pythondocker
Domain
backenddevopsapi
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonDocker
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70