TauCetiStation/TauCetiClassic

Не полные списки совместимых в некоторых магических спеллах

Open

#2,016 opened on Nov 27, 2017

View on GitHub
 (2 comments) (0 reactions) (0 assignees)DM (433 forks)batch import
BugGood First IssueOld issue

Repository metrics

Stars
 (153 stars)
PR merge metrics
 (Avg merge 27d 14h) (41 merged PRs in 30d)

Description

https://github.com/TauCetiStation/TauCetiClassic/blob/fce27146b2457fabc0f2adcee5c210b5266d12aa/code/datums/spells/mind_transfer.dm#L14 https://github.com/TauCetiStation/TauCetiClassic/blob/8e08ac2e808db83af5c44b6e944085a49febb1a6/code/datums/spells/barnyardcurse.dm#L20

Ниже как правило точное сравнение target.type in compatible_mobs, соответственно всякие ксеносы отпадают. Возможно стоит проход по списку и проверку на istype делать.

Обратил внимание после #2009, спасибо Unforg1v3n

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Contributor guide

Research direction
Inspect the magic spell code and change the compatibility check from exact type match to istype to include xenomorphs and other subtypes.
Tech stack
None
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65