TauCetiStation/TauCetiClassic

Рантайм особки если держать меню выбора особки после старта раунда

Open

#8,867 opened on Mar 18, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)DM (433 forks)batch import
BugGood First Issue

Repository metrics

Stars
 (153 stars)
PR merge metrics
 (Avg merge 27d 14h) (41 merged PRs in 30d)

Description

Подробное описание проблемы

Если нажать на кнопку быть особенным и держать подтверждение выбора аж до после спавна куклы, а потом нажать кнопку - будет рантайм

Как повторить

  1. нажать QUALITY [x]
  2. Дождаться начала раунда
  3. Нажать Да!!!

Дополнительная информация:

[02:04:16] Runtime in qualities.dm:31 : Cannot read null.prefs proc name: register client (/datum/controller/subsystem/qualities/proc/register_client) usr: Luduk () (/mob/dead/new_player) src: Qualities (/datum/controller/subsystem/qualities) call stack: Qualities (/datum/controller/subsystem/qualities): register client(null) Luduk (/mob/dead/new_player): Topic("src=[0x300000c];lobby_be_spec...", /list (/list)) Luduk (/client): Topic("src=[0x300000c];lobby_be_spec...", /list (/list), Luduk (/mob/dead/new_player))

Contributor guide

Research direction
Examine qualities.dm line 31 and ensure the client reference is not null before accessing its prefs.
Tech stack
None
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80