ThePhrozenKeep/D2MOO

Have a clean way to declare and reference packet tables

Open

#100 opened on Jan 23, 2023

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (48 forks)auto 404
enhancementgood first issue

Repository metrics

Stars
 (159 stars)
PR merge metrics
 (PR metrics pending)

Description

In D2Net Client.cpp, the size of the packet sizes table (std::size(gServerPacketSizeTable)) is hardcoded (0xB4).

We should probably have a constant for this, or put the table in its own header since it should only be included in D2Net's Client.cpp and Server.cpp.

Originally posted by @Lectem in https://github.com/ThePhrozenKeep/D2MOO/pull/96#discussion_r1083280497

Contributor guide

Research direction
Tech stack
Domain
Issue type
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Prerequisites
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.