ThePhrozenKeep/D2MOO

`ACT1Q1_Callback08_MonsterKilled` set flags incorrectly.

Open

#226 opened on Jul 8, 2026

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (48 forks)auto 404
buggood first issue

Repository metrics

Stars
 (159 stars)
PR merge metrics
 (PR metrics pending)

Description

https://github.com/ThePhrozenKeep/D2MOO/blob/19019806df7f3e877fa105b05395d1e3597e2316/source/D2Game/src/QUESTS/ACT1/A1Q1.cpp#L352

https://github.com/ThePhrozenKeep/D2MOO/blob/19019806df7f3e877fa105b05395d1e3597e2316/source/D2Game/src/QUESTS/ACT1/A1Q1.cpp#L358

these two lines bitwise OR the flag value (0x20), but the actual code from 1.13c assigns the value:

04125907 .  C647 14 20 MOV BYTE PTR [EDI+14],20

0412594D .  C647 14 20 MOV BYTE PTR [EDI+14],20

D2Game is based at 040C0000

pQuestData->dwFlags is only ever used to update the quest log, so this only affects the two quests that have progress updates via the log (DoE & Rescue on Mt Arreat), however this update is only ever going to start from zero or 0x20, so it is unnoticeable when playing.

this also happens to be one of only two places where the flags are ever set to anything other than zero, the other function, ACT5Q2_UpdateQuestState has the same bug: https://github.com/ThePhrozenKeep/D2MOO/blob/19019806df7f3e877fa105b05395d1e3597e2316/source/D2Game/src/QUESTS/ACT5/A5Q2.cpp#L982

the assembly from 1.10:

6FCB3218 |.  C643 14 20 MOV BYTE PTR [EBX+14],20

Contributor guide

Research direction
Tech stack
Domain
Issue type
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Prerequisites
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.