W4RH4WK/Debloat-Windows-10

Recommendation: Move the DNS/IPs out of hardcoded variables and into their own separate text files

Open

#301 opened on May 18, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)PowerShell (804 forks)batch import
help wanted

Repository metrics

Stars
 (6,158 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I'm not sure if this repo is maintained anymore, but just from a QoL/best practice perspective, I found it interesting that the server names and IPs were hardcoded into the PowerShell scripts. This makes it difficult to read the raw data if one wanted to say, import the list into Pi-Hole and block the servers from the network. From a maintenance perspective, it also separates the script's functional portions from the ephemeral data (i.e., the ever-changing servers/IPs).

Could it be possible to move the server names/IPs specified in the debloat ps1 files to their own separate and sanitized text files?

Contributor guide