actualbudget/actual

[Bug]: Transactions not merged when applying rules to existing transactions

Open

#1,331 opened on Jul 12, 2023

View on GitHub
 (0 comments) (1 reaction) (0 assignees)JavaScript (603 forks)batch import
bughelp wantedrulestransactions

Repository metrics

Stars
 (7,129 stars)
PR merge metrics
 (Avg merge 4d 15h) (165 merged PRs in 30d)

Description

Verified issue does not already exist?

  • I have searched and found no existing issue

What happened?

  1. Create account A
  2. Create account B
  3. Create a transaction in account A with payee b for an amount of 25.
  4. Create a transaction in account B with payee a for an amount of -25.
  5. Create rules to replace payee a with the account A, and payee b with the account B.
  6. In the edit window for the rules, select the existing transaction and click "Apply actions".

The result is that account A has -50 and account B has 50 due to the transactions not being merged.

What error did you receive?

No response

Where are you hosting Actual?

None

What browsers are you seeing the problem on?

No response

Operating System

None

Contributor guide

Research direction
Investigate the rule application logic to understand why transactions are not being merged when applying rules to existing transactions. Trace the code path from the 'Apply actions' button to the merging step.
Tech stack
javascript
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75