actualbudget/actual

[Maintenance] TypeScript migration

Open

#1,483 opened on Aug 7, 2023

View on GitHub
 (15 comments) (0 reactions) (0 assignees)JavaScript (603 forks)batch import
good first issuehelp wantedmaintenance

Repository metrics

Stars
 (7,129 stars)
PR merge metrics
 (Avg merge 4d 15h) (165 merged PRs in 30d)

Description

We are currently at around 50% TypeScript. There is still lots of work to be done to get to 100%.

Feel free to help out by converting a file here and there. Also hardening the existing TS files is welcome (i.e. converting unknown and any to more strict types).

Please do not send massive migration PRs. Try to keep it small and isolated.

Remaining files:

  • packages/desktop-client/src/components/accounts/Account.jsx - https://github.com/actualbudget/actual/pull/3311
  • packages/desktop-client/src/components/accounts/AccountSyncCheck.jsx
  • packages/desktop-client/src/components/accounts/Balance.jsx
  • packages/desktop-client/src/components/accounts/Header.jsx - https://github.com/actualbudget/actual/pull/3640
  • packages/desktop-client/src/components/accounts/Reconcile.jsx - https://github.com/actualbudget/actual/pull/3355
  • packages/desktop-client/src/components/budget/BudgetCategories.jsx - https://github.com/actualbudget/actual/pull/5961
  • packages/desktop-client/src/components/budget/BudgetTable.jsx
  • packages/desktop-client/src/components/filters/FiltersMenu.jsx - https://github.com/actualbudget/actual/pull/6091
  • packages/desktop-client/src/components/manager/ManagementApp.jsx
  • packages/desktop-client/src/components/mobile/accounts/Account.jsx
  • packages/desktop-client/src/components/mobile/accounts/Accounts.jsx
  • packages/desktop-client/src/components/mobile/accounts/AccountTransactions.jsx
  • packages/desktop-client/src/components/mobile/budget/BudgetTable.jsx - https://github.com/actualbudget/actual/pull/5997
  • packages/desktop-client/src/components/mobile/budget/CategoryTransactions.jsx
  • packages/desktop-client/src/components/mobile/transactions/TransactionEdit.jsx - https://github.com/actualbudget/actual/pull/5998
  • packages/desktop-client/src/components/mobile/transactions/TransactionList.jsx - https://github.com/actualbudget/actual/pull/4063
  • packages/desktop-client/src/components/mobile/transactions/TransactionListWithBalances.jsx
  • packages/desktop-client/src/components/modals/EditField.jsx
  • packages/desktop-client/src/components/modals/EditRuleModal.jsx
  • packages/desktop-client/src/components/modals/ImportTransactions.jsx - https://github.com/actualbudget/actual/pull/3570
  • packages/desktop-client/src/components/modals/ImportTransactions.test.js - https://github.com/actualbudget/actual/pull/3570
  • packages/desktop-client/src/components/modals/LoadBackup.jsx - https://github.com/actualbudget/actual/pull/3507
  • packages/desktop-client/src/components/modals/MergeUnusedPayees.jsx
  • packages/desktop-client/src/components/modals/SelectLinkedAccountsModal.jsx - https://github.com/actualbudget/actual/pull/5059
  • packages/desktop-client/src/components/payees/ManagePayees.jsx - https://github.com/actualbudget/actual/pull/3507
  • packages/desktop-client/src/components/payees/ManagePayeesPage.jsx
  • packages/desktop-client/src/components/payees/ManagePayeesWithData.jsx
  • packages/desktop-client/src/components/reports/Header.jsx
  • packages/desktop-client/src/components/reports/reports/NetWorth.jsx - https://github.com/actualbudget/actual/pull/3576
  • packages/desktop-client/src/components/schedules/PostsOfflineNotification.jsx
  • packages/desktop-client/src/components/schedules/ScheduleDetails.jsx
  • packages/desktop-client/src/components/select/RecurringSchedulePicker.jsx - https://github.com/actualbudget/actual/pull/3396
  • packages/desktop-client/src/components/transactions/SelectedTransactionsButton.jsx - https://github.com/actualbudget/actual/pull/3640
  • packages/desktop-client/src/components/transactions/SimpleTransactionsTable.jsx
  • packages/desktop-client/src/components/transactions/TransactionList.jsx
  • packages/desktop-client/src/components/transactions/TransactionsTable.jsx
  • packages/desktop-client/src/components/transactions/TransactionsTable.test.jsx
  • packages/desktop-client/src/components/util/GenericInput.jsx - https://github.com/actualbudget/actual/pull/5976
  • packages/desktop-client/src/hooks/useSplitsExpanded.jsx
  • packages/component-library/src/icons/add-attribute.js
  • packages/loot-core/src/platform/server/indexeddb/index.js
  • packages/api/app/query.js
  • packages/api/validateNodeVersion.js
  • packages/sync-server/migrations/1694360000000-create-folders.js
  • packages/sync-server/migrations/1694360479680-create-account-db.js
  • packages/sync-server/migrations/1694362247011-create-secret-table.js
  • packages/sync-server/migrations/1702667624000-rename-nordigen-secrets.js
  • packages/sync-server/migrations/1718889148000-openid.js
  • packages/sync-server/migrations/1719409568000-multiuser.js
  • packages/sync-server/migrations/1763873568237-server-global-prefs.js
  • packages/sync-server/migrations/1763873600000-backfill-files-owner.js
  • packages/sync-server/src/account-db.js
  • packages/sync-server/src/accounts/password.js
  • packages/sync-server/src/app-account.js
  • packages/sync-server/src/app-account.test.js
  • packages/sync-server/src/app-admin.js
  • packages/sync-server/src/app-admin.test.js
  • packages/sync-server/src/app-cors-proxy.js
  • packages/sync-server/src/app-cors-proxy.test.js
  • packages/sync-server/src/app-gocardless/app-gocardless.js
  • packages/sync-server/src/app-gocardless/bank-factory.js
  • packages/sync-server/src/app-gocardless/banks/abanca_caglesmm.js
  • packages/sync-server/src/app-gocardless/banks/abnamro_abnanl2a.js
  • packages/sync-server/src/app-gocardless/banks/american_express_aesudef1.js
  • packages/sync-server/src/app-gocardless/banks/bancsabadell_bsabesbbb.js
  • packages/sync-server/src/app-gocardless/banks/bank_of_ireland_b365_bofiie2d.js
  • packages/sync-server/src/app-gocardless/banks/bankinter_bkbkesmm.js
  • packages/sync-server/src/app-gocardless/banks/belfius_gkccbebb.js
  • packages/sync-server/src/app-gocardless/banks/berliner_sparkasse_beladebexxx.js
  • packages/sync-server/src/app-gocardless/banks/bnp_be_gebabebb.js
  • packages/sync-server/src/app-gocardless/banks/boursobank_bousfrppxxx.js
  • packages/sync-server/src/app-gocardless/banks/bper_retail_bpmoit22.js
  • packages/sync-server/src/app-gocardless/banks/cbc_cregbebb.js
  • packages/sync-server/src/app-gocardless/banks/cetelem_cetmptp1xxx.js
  • packages/sync-server/src/app-gocardless/banks/commerzbank_cobadeff.js
  • packages/sync-server/src/app-gocardless/banks/danskebank_privat.js
  • packages/sync-server/src/app-gocardless/banks/direkt_heladef1822.js
  • packages/sync-server/src/app-gocardless/banks/easybank_bawaatww.js
  • packages/sync-server/src/app-gocardless/banks/entercard_swednokk.js
  • packages/sync-server/src/app-gocardless/banks/fortuneo_ftnofrp1xxx.js
  • packages/sync-server/src/app-gocardless/banks/hype_hyeeit22.js
  • packages/sync-server/src/app-gocardless/banks/ing_ingbrobu.js
  • packages/sync-server/src/app-gocardless/banks/ing_ingddeff.js
  • packages/sync-server/src/app-gocardless/banks/ing_pl_ingbplpw.js
  • packages/sync-server/src/app-gocardless/banks/integration-bank.js
  • packages/sync-server/src/app-gocardless/banks/isybank_itbbitmm.js
  • packages/sync-server/src/app-gocardless/banks/kbc_kredbebb.js
  • packages/sync-server/src/app-gocardless/banks/lhv_lhvbee22.js
  • packages/sync-server/src/app-gocardless/banks/mbank_retail_brexplpw.js
  • packages/sync-server/src/app-gocardless/banks/nationwide_naiagb21.js
  • packages/sync-server/src/app-gocardless/banks/nbg_ethngraaxxx.js
  • packages/sync-server/src/app-gocardless/banks/norwegian_xx_norwnok1.js
  • packages/sync-server/src/app-gocardless/banks/raiffeisen_at_rzbaatww.js
  • packages/sync-server/src/app-gocardless/banks/revolut_revolt21.js
  • packages/sync-server/src/app-gocardless/banks/sandboxfinance_sfin0000.js
  • packages/sync-server/src/app-gocardless/banks/seb_kort_bank_ab.js
  • packages/sync-server/src/app-gocardless/banks/seb_privat.js
  • packages/sync-server/src/app-gocardless/banks/sparnord_spnodk22.js
  • packages/sync-server/src/app-gocardless/banks/spk_karlsruhe_karsde66.js
  • packages/sync-server/src/app-gocardless/banks/spk_marburg_biedenkopf_heladef1mar.js
  • packages/sync-server/src/app-gocardless/banks/spk_worms_alzey_ried_malade51wor.js
  • packages/sync-server/src/app-gocardless/banks/ssk_dusseldorf_dussdeddxxx.js
  • packages/sync-server/src/app-gocardless/banks/ssk_munchen.js
  • packages/sync-server/src/app-gocardless/banks/swedbank_habalv22.js
  • packages/sync-server/src/app-gocardless/banks/tests/abanca_caglesmm.spec.js
  • packages/sync-server/src/app-gocardless/banks/tests/abnamro_abnanl2a.spec.js
  • packages/sync-server/src/app-gocardless/banks/tests/bancsabadell_bsabesbbb.spec.js
  • packages/sync-server/src/app-gocardless/banks/tests/belfius_gkccbebb.spec.js
  • packages/sync-server/src/app-gocardless/banks/tests/boursobank_bousfrppxxx.spec.js
  • packages/sync-server/src/app-gocardless/banks/tests/bper_retail_bpmoit22.spec.js
  • packages/sync-server/src/app-gocardless/banks/tests/cbc_cregbebb.spec.js
  • packages/sync-server/src/app-gocardless/banks/tests/commerzbank_cobadeff.spec.js
  • packages/sync-server/src/app-gocardless/banks/tests/easybank_bawaatww.spec.js
  • packages/sync-server/src/app-gocardless/banks/tests/fortuneo_ftnofrp1xxx.spec.js
  • packages/sync-server/src/app-gocardless/banks/tests/ing_ingddeff.spec.js
  • packages/sync-server/src/app-gocardless/banks/tests/ing_pl_ingbplpw.spec.js
  • packages/sync-server/src/app-gocardless/banks/tests/integration_bank.spec.js
  • packages/sync-server/src/app-gocardless/banks/tests/kbc_kredbebb.spec.js
  • packages/sync-server/src/app-gocardless/banks/tests/lhv_lhvbee22.spec.js
  • packages/sync-server/src/app-gocardless/banks/tests/mbank_retail_brexplpw.spec.js
  • packages/sync-server/src/app-gocardless/banks/tests/nationwide_naiagb21.spec.js
  • packages/sync-server/src/app-gocardless/banks/tests/nbg_ethngraaxxx.spec.js
  • packages/sync-server/src/app-gocardless/banks/tests/raiffeisen_at_rzbaatww.spec.js
  • packages/sync-server/src/app-gocardless/banks/tests/revolut_revolt21.spec.js
  • packages/sync-server/src/app-gocardless/banks/tests/sandboxfinance_sfin0000.spec.js
  • packages/sync-server/src/app-gocardless/banks/tests/spk_marburg_biedenkopf_heladef1mar.spec.js
  • packages/sync-server/src/app-gocardless/banks/tests/ssk_dusseldorf_dussdeddxxx.spec.js
  • packages/sync-server/src/app-gocardless/banks/tests/swedbank_habalv22.spec.js
  • packages/sync-server/src/app-gocardless/banks/tests/virgin_nrnbgb22.spec.js
  • packages/sync-server/src/app-gocardless/banks/util/escape-regexp.js
  • packages/sync-server/src/app-gocardless/banks/util/extract-payeeName-from-remittanceInfo.js
  • packages/sync-server/src/app-gocardless/banks/virgin_nrnbgb22.js
  • packages/sync-server/src/app-gocardless/services/tests/fixtures.js
  • packages/sync-server/src/app-gocardless/services/tests/gocardless-service.spec.js
  • packages/sync-server/src/app-gocardless/tests/bank-factory.spec.js
  • packages/sync-server/src/app-gocardless/tests/utils.spec.js
  • packages/sync-server/src/app-gocardless/util/handle-error.js
  • packages/sync-server/src/app-gocardless/utils.js
  • packages/sync-server/src/app-pluggyai/app-pluggyai.js
  • packages/sync-server/src/app-pluggyai/pluggyai-service.js
  • packages/sync-server/src/app-secrets.js
  • packages/sync-server/src/app-simplefin/app-simplefin.js
  • packages/sync-server/src/app-sync/errors.js
  • packages/sync-server/src/app-sync/tests/services/files-service.test.js
  • packages/sync-server/src/app-sync/validation.js
  • packages/sync-server/src/db.js
  • packages/sync-server/src/load-config.js
  • packages/sync-server/src/load-config.test.js
  • packages/sync-server/src/scripts/disable-openid.js
  • packages/sync-server/src/scripts/enable-openid.js
  • packages/sync-server/src/scripts/health-check.js
  • packages/sync-server/src/scripts/reset-password.js
  • packages/sync-server/src/scripts/run-migrations.js
  • packages/sync-server/src/secrets.test.js
  • packages/sync-server/src/services/secrets-service.js
  • packages/sync-server/src/sync-simple.js
  • packages/sync-server/src/util/title/index.js
  • packages/sync-server/src/util/title/lower-case.js
  • packages/sync-server/src/util/title/specials.js

Contributor guide

Research direction
Pick a remaining file from the list and convert it to TypeScript, adding proper types and removing 'any' or 'unknown' where possible. Ensure the file compiles and passes tests.
Tech stack
javascripttypescriptreact
Domain
frontendbackend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptTypeScriptReact
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75