actualbudget/actual

[Bug]: Rules/schedule modal should reopen when undoing a rule application

Open

#1,945 opened on Nov 21, 2023

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (603 forks)batch import
bughelp wantedrulesuser interface

Repository metrics

Stars
 (7,129 stars)
PR merge metrics
 (Avg merge 4d 15h) (165 merged PRs in 30d)

Description

Verified issue does not already exist?

  • I have searched and found no existing issue

What happened?

To reproduce:

  1. Add a rule that matches a transaction, and apply a change via that rule.
  2. Switch to the transactions page.
  3. Hit Ctrl/Cmd-Z and see that the rule modal you previously had open is no longer open.

I would expect this to reopen the previous rule-edit modal because that's where I previously made the change. This is important if you have a ton of rules, because then sending the user back to the rules page is pretty confusing (which rule did I just undo?).

What error did you receive?

n/a

Where are you hosting Actual?

Fly.io

What browsers are you seeing the problem on?

Chrome

Operating System

Mac OSX

Contributor guide

Research direction
Trace the undo action for rule application and ensure the modal reopens after undo.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65