actualbudget/actual

[Bug]: Can't click off to close filter menu with select open

Open

#3,051 opened on Jul 13, 2024

View on GitHub
 (5 comments) (2 reactions) (0 assignees)JavaScript (603 forks)batch import
buggood first issuehelp wanted

Repository metrics

Stars
 (7,129 stars)
PR merge metrics
 (Avg merge 4d 15h) (165 merged PRs in 30d)

Description

Verified issue does not already exist?

  • I have searched and found no existing issue
  • I will be providing steps how to reproduce the bug (in most cases this will also mean uploading a demo budget file)

What happened?

Video below for reproduction. If you open a filter modal (popover?) with a select box open (eg category one of), you can no longer click off to close the whole thing. You must first click off the select, then you can click off the filter.

https://github.com/user-attachments/assets/4d07c034-3219-4858-b41a-0d34ec7e672c

Where are you hosting Actual?

Locally via Yarn

What browsers are you seeing the problem on?

Chrome

Operating System

Windows 11

Contributor guide

Research direction
Investigate the filter modal's click outside handler to ensure it works when a nested select is open.
Tech stack
javascriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScriptReact
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65