adobe/aem-project-archetype

Improve error 404/500 handling

Open

#290 opened on Dec 3, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (430 forks)auto 404
enhancementgood first issue

Repository metrics

Stars
 (594 stars)
PR merge metrics
 (PR metrics pending)

Description

The error 404/500 error handling solution provided by the archetype [0] is not very robust and seems difficult to achieve a "pretty" error page. Instead, a Apache ErrorDirective solution [1] gives the flexibility to use actual content pages and is quite easy to set up (once you know the syntax).

While this might not be a complete solution for a multilingual setup (the error code is using the us-en locale for all errors), it seems like a good start and the direction we can move towards.

[0] https://github.com/adobe/aem-project-archetype/tree/master/src/main/archetype/ui.apps/src/main/content/jcr_root/apps/sling/servlet/errorhandler [1] https://github.com/adobe/aem-guides-wknd/pull/61

Contributor guide

Research direction
Tech stack
Domain
Issue type
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Prerequisites
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.