akinsho/toggleterm.nvim

[Bug] First hidden terminal is re-opened using {count}ToggleTerm command

Open

#322 opened on Sep 23, 2022

View on GitHub
 (19 comments) (0 reactions) (0 assignees)Lua (203 forks)batch import
bughelp wantedlow priority

Repository metrics

Stars
 (5,501 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

If the first terminal I open in toggleterm is a hidden one with Terminal:new (floating), then :1ToggleTerm opens the hidden terminal instead a new one. Is there a way to prevent this?

My config:

local status, toggleterm = pcall(require, 'toggleterm')
if (not status) then return end

toggleterm.setup({
  open_mapping = '†', -- Alt-Gr + t
  insert_mappings = true,
  terminal_mappings = true,
  persist_size = false,
})

local Terminal = require('toggleterm.terminal').Terminal
local lazygit  = Terminal:new({ cmd = "source ~/.zshrc; lazygit", hidden = true, direction = 'float' })
vim.keymap.set({ "n", "t" }, "©", function() lazygit:toggle() end, { noremap = true, silent = true }) -- Alt-Gr + g

So basically I open lazygit with the mapping right after I open up vim and then put it in the background with the same command and then run :1ToggleTerm and it opens up again.

Contributor guide

Research direction
Investigate the logic of terminal indexing in toggleterm.nvim, specifically how hidden terminals are counted and how :1ToggleTerm selects a terminal. Consider why a hidden terminal is reopened instead of creating a new one. Look at the code for :ToggleTerm command and terminal creation/selection.
Tech stack
lua
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
LuaNeovimGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65