alanshaw/embed-video

Invalid URL causes error

Open

#14 opened on May 14, 2017

View on GitHub
 (1 comment) (2 reactions) (0 assignees)JavaScript (27 forks)github user discovery
help wanted

Repository metrics

Stars
 (73 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

When the the URL is invalid, we the error Uncaught TypeError: Cannot read property 'indexOf' of null. I'll add a fix for the issue.

Contributor guide

Research direction
Identify where the URL string is used with .indexOf() without null check, then add a guard condition to handle invalid URLs.
Tech stack
javascript
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80