andreypopp/autobind-decorator

Break sinon.spy(Component.prototype, 'method')

Open

#47 opened on May 7, 2017

View on GitHub
 (8 comments) (1 reaction) (0 assignees)JavaScript (76 forks)batch import
PR welcomehelp wanted

Repository metrics

Stars
 (1,446 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

When using '@autobind' on a component, then in tests sinon.spy(Component.prototype, 'someMethod') will yield an error:

TypeError: Attempted to wrap undefined property undefined as function
...

Sorry, currently I can't provide more detail, but I'm sure @autobind is the only variable between success/error in tests.

Contributor guide

Research direction
Create a minimal test case that reproduces the error. Verify that the method exists on Component.prototype before using sinon.spy. Check if @autobind modifies the property descriptor such that the method is not enumerable or not configurable.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Needs investigation
Prerequisites
JavaScriptSinon
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60