andreypopp/autobind-decorator

If bound methods or fields are re-assigned, they become shared between instances

Open

#76 opened on Nov 16, 2018

View on GitHub
 (8 comments) (0 reactions) (0 assignees)JavaScript (76 forks)batch import
PR welcomebughelp wanted

Repository metrics

Stars
 (1,446 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

If bound methods or fields are re-assigned, they become shared between instances

Found this issue while trying to debounce bound method

Below test will fail

class A {
  @boundMethod
  bound() {}
}

const a = new A();
const b = new A();
a.bound = {
  foo: 'bar'
};
assert.notEqual(a.bound, b.bound);

Contributor guide

Research direction
Investigate how the autobind decorator stores bound methods. The issue suggests that reassigning a bound method on an instance shares the modification with other instances. Look for a shared cache or prototype level reference that should be instance specific.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptdecorators
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60