ansible-collections/community.postgresql

String value pulled from postgres and present in settings dictionary compared incorrectly

Open

#597 opened on Oct 4, 2023

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (116 forks)auto 404
help wanted

Repository metrics

Stars
 (142 stars)
PR merge metrics
 (PR metrics pending)

Description

SUMMARY

String value pulled from postgres and present in settings dictionary compared incorrectly

ISSUE TYPE
  • Bug Report
COMPONENT NAME

plugins/modules/postgresql_set.py

ANSIBLE VERSION
COLLECTION VERSION
CONFIGURATION
OS / ENVIRONMENT

not depends

STEPS TO REPRODUCE
      - name: shared_preload_libraries
        value: 'pg_stat_statements,pg_stat_kcache,pg_background'
EXPECTED RESULTS

resulting config

...
shared_preload_libraries = 'pg_stat_statements, pg_stat_kcache, pg_background'
...

should be no change and restart on second run w/o changes
ACTUAL RESULTS

value: 'pg_stat_statements,pg_stat_kcache,pg_background'

should pass the prettyfier before being compared with effective value

Contributor guide

Research direction
Inspect the comparison logic in plugins/modules/postgresql set.py. The issue is that the string value from the database (e.g., 'pg stat statements, pg stat kcache, pg background') is not being compared correctly with the desired value from the playbook (e.g., 'pg stat statements,pg stat kcache,pg background') because the database value may have spaces after commas. The fix should normalize both values before comparison, likely by stripping spaces around commas or using a consistent formatting function.
Tech stack
python
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65