ansible/awx

awx workflow_jobs monitor does not show approval nodes

Open

#7,558 opened on Jul 6, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (3,333 forks)batch import
component:clihelp wantedtype:bug

Repository metrics

Stars
 (13,071 stars)
PR merge metrics
 (Avg merge 24d 6h) (30 merged PRs in 30d)

Description

ISSUE TYPE
  • Bug Report
SUMMARY

while testing out https://github.com/ansible/awx/pull/6790 I noticed that a workflow that has a approval node does not show this in the monitor output.

 awx workflow_jobs monitor 33
------Starting Standard Out Stream------
Launching foo...
 ↳ 34 - ansible-examples.git (git) successful
 ↳ 36 - JobTemplate - AgentBuyer鈑 successful
 ↳ 35 - inventory-aws - inventory-aws successful
------End of Standard Out Stream--------

hangs out until the approval nodes does exit either by approving, denying or timing out (probably because workflow itself shows itself as not done) but does not show that it is waiting on an approval node.

Contributor guide

Research direction
Examine the `awx workflow jobs monitor` command implementation to understand how it displays job nodes. Locate where approval nodes are handled and add logic to display their status (waiting, approved, denied, timed out).
Tech stack
python
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Python
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45