apache/gravitino

[Improvement] Remove warnings when compiling Gravitino

Open

#1,809 opened on Jan 31, 2024

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Java (887 forks)auto 404
good first issueimprovement

Repository metrics

Stars
 (3,058 stars)
PR merge metrics
 (PR metrics pending)

Description

What would you like to be improved?

Warning shows up when compiling Gravitino, adding -Xlint:unchecked gives this:

> Task :common:compileJava FAILED
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/util/DTOConverters.java:82: warning: [unchecked] unchecked call to withProperties(Map<String,String>) as a member of the raw type Builder
        .withProperties(metalake.properties())
                       ^
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/util/DTOConverters.java:132: warning: [unchecked] unchecked call to withProperties(Map<String,String>) as a member of the raw type Builder
        .withProperties(catalog.properties())
                       ^
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/util/DTOConverters.java:141: warning: [unchecked] unchecked call to withProperties(Map<String,String>) as a member of the raw type Builder
        .withProperties(schema.properties())
                       ^
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/util/DTOConverters.java:167: warning: [unchecked] unchecked call to withProperties(Map<String,String>) as a member of the raw type Builder
        .withProperties(table.properties())
                       ^
  where S is a type-variable:
    S extends Builder declared in class Builder
error: warnings found and -Werror specified
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/AuditDTO.java:90: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/AuditDTO.java:101: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/AuditDTO.java:112: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/AuditDTO.java:123: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/MetalakeDTO.java:86: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/MetalakeDTO.java:97: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/MetalakeDTO.java:108: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/MetalakeDTO.java:119: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/CatalogDTO.java:112: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/CatalogDTO.java:123: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/CatalogDTO.java:134: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/CatalogDTO.java:145: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/CatalogDTO.java:156: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/CatalogDTO.java:167: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/SchemaDTO.java:86: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/SchemaDTO.java:97: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/SchemaDTO.java:108: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/SchemaDTO.java:119: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/ColumnDTO.java:141: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/ColumnDTO.java:152: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/ColumnDTO.java:163: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/ColumnDTO.java:174: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/ColumnDTO.java:185: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/ColumnDTO.java:190: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/TableDTO.java:164: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/TableDTO.java:175: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/TableDTO.java:186: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/TableDTO.java:197: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/TableDTO.java:208: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/TableDTO.java:213: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/TableDTO.java:218: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/TableDTO.java:223: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/TableDTO.java:228: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/indexes/IndexDTO.java:93: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/indexes/IndexDTO.java:98: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/indexes/IndexDTO.java:103: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
1 error
40 warnings

How should we improve?

Remove the warnings. This is required by https://www.bestpractices.dev/en

Contributor guide

Research direction
Add generic type parameters to Builder classes in DTOConverters.java and DTO files (AuditDTO, MetalakeDTO, CatalogDTO, SchemaDTO, ColumnDTO, TableDTO, IndexDTO) to eliminate unchecked warnings. Ensure the withProperties method and cast statements use proper generic types.
Tech stack
java
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaGenerics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80