apache/gravitino

[Improvement] In Distribution.java correct equals method

Open

#2,286 opened on Feb 21, 2024

View on GitHub
 (14 comments) (0 reactions) (0 assignees)Java (887 forks)auto 404
good first issueimprovement

Repository metrics

Stars
 (3,058 stars)
PR merge metrics
 (PR metrics pending)

Description

What would you like to be improved?

The Object class contains an equals method, a method called equals should in general override Object.equals(Object).

How should we improve?

A method called equals should override Object.equals(Object) or that is not its intent it should be renamed.

Contributor guide

Research direction
Inspect the equals method in Distribution.java to determine if it is intended to override Object.equals(Object). If not, rename it to avoid confusion (e.g., equalsDistribution). If yes, ensure the method signature matches Object.equals(Object) and add @Override annotation.
Tech stack
java
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaObject Oriented Programming
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85