apache/gravitino

[Improvement] Improve GravitinoCatalogManager close method

Open

#2,911 opened on Apr 12, 2024

View on GitHub
 (7 comments) (0 reactions) (0 assignees)Java (887 forks)auto 404
good first issueimprovement

Repository metrics

Stars
 (3,058 stars)
PR merge metrics
 (PR metrics pending)

Description

What would you like to be improved?

GravitinoCatalogManager's close method mixes static and volatile variables in a nonstatic method and that may cause issues. Correctly updating a static field from a non-static method can be tricky to get right and could easily lead to bugs if there are multiple threads.

How should we improve?

See if this can be improved to be more thread safe.

Contributor guide

Research direction
Analyze the GravitinoCatalogManager.close method, identify the mix of static and volatile variables, and propose a thread safe refactoring.
Tech stack
java
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Javaconcurrency
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65