apache/gravitino

[Improvement] Possible SQL injection in MysqlDatabaseOperations.java and JdbcDatabaseOperations.java

Open

#3,026 opened on Apr 19, 2024

View on GitHub
 (6 comments) (0 reactions) (1 assignee)Java (887 forks)auto 404
good first issueimprovement

Repository metrics

Stars
 (3,058 stars)
PR merge metrics
 (PR metrics pending)

Description

What would you like to be improved?

The database name should be validated before but used to construct an SQL to show tables. (Search for "SHOW TABLES IN".) Note that the SQL strings are also built in different ways in each file and probably should be built the same way.

How should we improve?

Validate the name or use query parameters.

Contributor guide

Research direction
Validate the database name before constructing SQL queries or use query parameters to prevent SQL injection. Review the methods building SHOW TABLES IN statements in both MysqlDatabaseOperations.java and JdbcDatabaseOperations.java and ensure consistent, parameterized queries.
Tech stack
java
Domain
backend
Issue type
Security
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaSQL
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60