apache/gravitino

[Improvement] Use of regex on error messages can be fragile in DorisExceptionConverter.java

Open

#3,027 opened on Apr 19, 2024

View on GitHub
 (11 comments) (0 reactions) (1 assignee)Java (887 forks)auto 404
good first issueimprovement

Repository metrics

Stars
 (3,058 stars)
PR merge metrics
 (PR metrics pending)

Description

What would you like to be improved?

DorisExceptionConverter.java uses a DATABASE_ALREADY_EXISTS_PATTERN_STRING regex to check error messages for databases that already exist. There are several issues with this and regex can be fragile expensive or even a possible DOS vector

How should we improve?

If possible improve code to not use regexp for this error condition.

Contributor guide

Research direction
Examine the DATABASE ALREADY EXISTS PATTERN STRING regex usage in DorisExceptionConverter.java, identify the error message format from the database driver, and replace the regex match with a direct string check or structured exception handling.
Tech stack
java
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Javaregex
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60