apache/gravitino

[Improvement] Possible SQL injection in MysqlDatabaseOperations.java

Open

#4,211 opened on Jul 19, 2024

View on GitHub
 (6 comments) (0 reactions) (0 assignees)Java (887 forks)auto 404
good first issueimprovement

Repository metrics

Stars
 (3,058 stars)
PR merge metrics
 (PR metrics pending)

Description

What would you like to be improved?

databaseName in generateDropDatabaseSql is not validated for any potential SQL issues.

How should we improve?

Validate databaseName

Contributor guide

Research direction
Examine the `generateDropDatabaseSql` method in `MysqlDatabaseOperations.java` and add validation for the `databaseName` parameter to prevent SQL injection. Consider using parameterized queries or whitelist validation.
Tech stack
java
Domain
backend
Issue type
Security
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaSQL
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60