apple/turicreate

trailing slash prevents sarray loading from s3

Open

#3,109 opened on Apr 9, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (1,161 forks)batch import
S3good first issue

Repository metrics

Stars
 (11,135 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

trailing slash will make sarray loading from s3 fail.

import turicreate as tc
tc.config.set_runtime_config("TURI_FILEIO_INSECURE_SSL_CERTIFICATE_CHECKS", 1)
gui = tc.SArray([1])

works with

gui = tc.load_sarray("s3://guihao/tiny_array")

but not with

gui = tc.load_sarray("s3://guihao/tiny_array/")

Surfaced by #3106

Contributor guide

Research direction
Investigate how SArray loads from S3 paths and implement handling for trailing slashes.
Tech stack
pythoncpp
Domain
backendapicloud
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonS3
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90