arrow-kt/arrow-meta

WhenExpression Quote and Template validation

Open

#348 opened on Dec 16, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Kotlin (43 forks)github user discovery
AST-scopedocumentationgood first issuehelp wanted

Repository metrics

Stars
 (408 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Parent issue: #335 Every plugin must be able to use all properties to construct the exact PSI element being fed in to achieve isomorphism between Quote and Scope. To ensure that AST parsing and our quote-and-template system is robust, more testing is needed to increase stability and reliability.

Checklist for WhenExpression

  • Destructure and make available all methods related to rendering properties (no logic or PsiElements)
  • Testing added for validation to ensure all properties can be used as a commutative identity.
  • Ensure documentation is updated in Property matches the example in PropertyPlugin
  • When confident about working unit tests, make sure WhenExpression is added to regression testing in QuoteTest.kt

Notes

  • Feel free to place the target branch for the PR to quote-and-template-minor-cleanups

Contributor guide

Research direction
Study the PropertyPlugin example and QuoteTest.kt regression tests to understand the validation pattern, then implement similar tests for WhenExpression, ensuring all properties are covered for commutative identity.
Tech stack
kotlin
Domain
tooling
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
KotlinGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65