authorjapps/zerocode

[TECH-DEBT] - Handle multivalue support for www urlencoded header

Open

#148 opened on Nov 2, 2018

View on GitHub
 (13 comments) (0 reactions) (0 assignees)Java (447 forks)auto 404
enhancementgood first issuehelp wanted

Repository metrics

Stars
 (1,010 stars)
PR merge metrics
 (PR metrics pending)

Description

This is a tech-debt ticket. Before implementing, please check if the framework(Apache Http Client) is already taking care of this situation. If not, then implement it and raise a PR. TODO-

  • Add an end point or use the existing end point in the Spring Boot demo repo to reproduce this
    • See the relevant repo/class in the below section
  • Add a simple brand new test-case with couple of Key-Values to the above repo
  • Please take care of "body" and "queryParams" while fixing the same.
    • The fix is similar for both. You might reuse the same code.

Spring boot repo: https://github.com/authorjapps/spring-boot-integration-test

Controller class: https://github.com/authorjapps/spring-boot-integration-test/blob/master/src/main/java/com/springboot/controller/CustomerController.java

Relevant comments from the old ticket: Comment Link: https://github.com/authorjapps/zerocode/issues/141#issuecomment-432700435

That sounds correct. 👍 This will make everyone's life a lot easy now. Postman accepts both as key-value and combines them if both are present(shown below).

Folks, Let's go with PR review n approval please !

postmna_body

  • Then in server app- postman_rq_rcvd

If same key is present, they server receives as multivalue(means client also sends as multi value) - see below:

  • postman client postman_2vals

  • spring boot server postman_2vals_server

@arunvelusamyd , Good job mate ! Have you taken care of the above(same key situation) in your PR ? If not can you please take care now ? 👍

@macrocks , @cooljavadev @nirmalchandra - Please review n approve -or- express your view points if disagree or think any other way 🙏

Contributor guide