avh4/elm-upgrade

Elm upgrade placing broken version number in elm.json

Open

#94 opened on Mar 28, 2021

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Perl (12 forks)github user discovery
bughelp wantedplatform: windows

Repository metrics

Stars
 (122 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Finally getting around to seeing if i can update an old project of mine. And for some reason the elm.json that is getting generated has a carriage return in it. This is on windows 10 with the latest elm-format, and elm, with the latest elm-upgrade.

Assistance would be appreciated.

`C:\GITHUB\PrismaPalette\gamut-commander\html>npx elm-upgrade@latest INFO: Found elm at node_modules.bin\elm.CMD INFO: Found elm 0.19.1 INFO: Found elm-format at node_modules.bin\elm-format.CMD INFO: Found elm-format 0.8.5 INFO: Cleaning ./elm-stuff before upgrading INFO: Converting elm-package.json -> elm.json INFO: Detected an application project (this project has no exposed modules) WARNING: MichaelCombs28/elm-mdl has not been upgraded to 0.19 yet! INFO: Installing latest version of debois/elm-dom -- PROBLEM WITH VERSION ----------------------------------------------- elm.json

I got stuck while reading your elm.json file. I was expecting a version number here:

8| "elm-version": "0.19.1\r", ^ I need something like "1.0.0" or "2.0.4" that explicitly states all three numbers!

WARNING: Failed to upgrade debois/elm-dom! INFO: Switching from elm-community/linear-algebra (deprecated) to elm-explorations/linear-algebra INFO: Installing latest version of elm-explorations/linear-algebra`

Contributor guide

Research direction
Investigate the code that writes the version string to elm.json, likely in the conversion from elm package.json or during elm.json creation. Look for places where a newline or carriage return might be introduced. Check for platform specific handling of line endings.
Tech stack
None
Domain
clitooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitElm
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75