aws/aws-nitro-enclaves-cli

Allocator service triggers EINVAL error in dmesg

Open

#397 opened on Jul 27, 2022

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Rust (101 forks)auto 404
good first issue

Repository metrics

Stars
 (151 stars)
PR merge metrics
 (PR metrics pending)

Description

This piece of code https://github.com/aws/aws-nitro-enclaves-cli/blame/main/bootstrap/nitro-enclaves-allocator#L129-L138 is called every time the allocator service is started.

It writes an empty string to /sys/module/nitro_enclaves/parameters/ne_cpus. The driver however doesn't know how to interpret this empty string (see https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/drivers/virt/nitro_enclaves/ne_misc_dev.c#n431) so it tries to allocate this invalid cpu pool, fails, then prints EINVAL to dmesg.

Everything works perfectly fine however, so no actual issue just that seeing errors in dmesg is super confusing when debugging other stuff.

Edit: this is not an issue with nitro-cli, just with the driver.

Contributor guide

Research direction
Tech stack
Domain
Issue type
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Prerequisites
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.