awslabs/benchmark-ai

[SM-Executor] Instance types

Open

#940 opened on Oct 14, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (6 forks)auto 404
buggood first issueservice:sm-executor

Repository metrics

Stars
 (19 stars)
PR merge metrics
 (PR metrics pending)

Description

SageMaker seems to expect instance types in the form ml.<instance-type>. This causes a disparity in the toml when defining a benchmark b/w kubernetes and sage maker.

We should update the sm-executor to check the user's input and if the instance type does not start with ml., add it under the covers...

Contributor guide

Research direction
Locate the SM Executor code where instance types are processed, add a check if the instance type does not start with 'ml.', then prepend it.
Tech stack
python
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60