awslabs/benchmark-ai

[Executor] Dangling resources on failed kubectl apply

Open

#943 opened on Oct 14, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (6 forks)auto 404
buggood first issueservice:executor

Repository metrics

Stars
 (19 stars)
PR merge metrics
 (PR metrics pending)

Description

The executor creates the kubernetes resources by executing a kubectl apply against a generated kubernetes resource file. Sometimes, these files can contain multiple resource definitions (Jobs, Pods, Services, Roles, etc.). This means that, while the command itself can fail (exit with non-zero), some of the (valid) kuberenetes resources would still be created.

We should issue a kubectl delete in case there is a failure. To ensure we don't leave any dangling resources in case of any failure.

Contributor guide

Research direction
Examine the executor code in the repository to find where kubectl apply is invoked, then implement a cleanup mechanism that runs kubectl delete on the generated resource file if the apply command fails.
Tech stack
pythonkubernetes
Domain
backenddevopsinfrastructure
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonKuberneteskubectl
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60