bitcoindevkit/bdk_wallet

Allow bump fee on transactions without RBF sequence

Open

#65 opened on Oct 18, 2024

View on GitHub
 (1 comment) (1 reaction) (0 assignees)Rust (94 forks)auto 404
good first issue

Repository metrics

Stars
 (54 stars)
PR merge metrics
 (PR metrics pending)

Description

This should be an easy change, the following lines need to be removed from Wallet::build_fee_bump: https://github.com/bitcoindevkit/bdk/blob/7969898c732a3a387a932a61b1719cedcb6fae3c/crates/wallet/src/wallet/mod.rs#L1636-L1644

Also related to this discussion (probably warrants a separate issue?) is how the new rules impact the bump fee transaction builder. I'm not sure if the current builder requires a transaction signals for RBF to then be used by the replace by fee txbuilder?

_Originally posted by @thunderbiscuit in https://github.com/bitcoindevkit/bdk_wallet/issues/66

Contributor guide

Research direction
Tech stack
Domain
Issue type
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Prerequisites
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.