brave/brave-browser

Brave components are re-downloaded to create profile folder when trying to uninstall

Open

#1,812 opened on Oct 23, 2018

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (2,164 forks)batch import
good first issuepriority/P5setup/installer

Repository metrics

Stars
 (16,194 stars)
PR merge metrics
 (Avg merge 4h 38m) (19 merged PRs in 30d)

Description

Description

Brave components are re-downloaded to create profile folder when trying to uninstall

Steps to Reproduce

  1. Rename browser profile to %userprofile%/Appdata/Local/BraveSoftware_Old/ and keep the local profile folder open
  2. Open Settings-> App-> Brave -> Uninstall
  3. Creates a browser profile and downloads Brave components
  4. Folder remains if user doesn't uncheck Remove user profile data from the uninstaller

Actual result:

profile

Expected result:

Should not recreate the profile folder when no profile folder exists

Reproduces how often:

Easy

Brave version (brave://version info)

All

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    Yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

cc: @simonhong @bbondy

Contributor guide

Research direction
Investigate the uninstaller mechanism to identify why it triggers profile creation and component downloads even when the profile folder does not exist. Focus on the removal logic and conditions for re downloading.
Tech stack
javascript
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50