brave/brave-browser

Update design for https warning interstitial

Open

#21,669 opened on Mar 15, 2022

View on GitHub
 (3 comments) (0 reactions) (1 assignee)JavaScript (2,164 forks)batch import
OS/DesktopQA/Yesfeature/https-everywheregood first issueneeds-text-changepriority/P4release-notes/include

Repository metrics

Stars
 (16,194 stars)
PR merge metrics
 (Avg merge 4h 38m) (19 merged PRs in 30d)

Description

Description

Current https only warning interstitial uses chromium look and feel and is not user friendly. Update design to assist users navigate through this warning.

Steps to Reproduce

  1. Turn on brave://settings/security Always use secure connections (https-only)
  2. Visit a site that's http only e.g. http://ejfry.com or http://howbigismybrowser.com or your choice
  3. Notice interstitial screen attached in actual result. Clicking through should take you to http site.

Actual result:

Image

Expected result:

Image

Reproduces how often:

easily

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

Required change before turning https-only on by default. cc: @diracdeltas @fmarier @iefremov @Brave-Matt

Contributor guide

Research direction
Study the current Brave HTTPS only interstitial implementation. Examine the Chromium source for SSL interstitials, then locate Brave's modifications (likely in `brave/` directories overriding Chromium WebUI). Understand the current UI components and styling. Propose a new design that matches Brave's brand guidelines, improving user experience and clarity. Consider using CSS, HTML, and potentially React components to update the interstitial.
Tech stack
cppjavascript
Domain
frontendsecurity
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++JavaScriptChromium interstitials
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40