brave/brave-browser

brave://apps has an ugly gray color as the background

Open

#25,736 opened on Sep 30, 2022

View on GitHub
 (19 comments) (0 reactions) (0 assignees)JavaScript (2,164 forks)batch import
OS/DesktopQA/Yesfeature/new-tabfeatures/appsgood first issuehelp wantedpriority/P5

Repository metrics

Stars
 (16,194 stars)
PR merge metrics
 (Avg merge 4h 38m) (19 merged PRs in 30d)

Description

Description

Ever since https://github.com/brave/brave-browser/issues/16078 was fixed, brave://apps has been displaying an ugly gray color as the background that doesn't suit the application theme at all.

Steps to Reproduce

  1. Navigate to brave://apps
  2. Notice that the background color is an ugly gray.

Actual result:

image

Expected result:

brave://apps background should match the selected Brave theme in settings.

Reproduces how often:

Every time

Brave version (brave://version info)

1.44.101 Chromium: 106.0.5249.65 (Official Build) (64-bit)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Not tested
  • Can you reproduce this issue with the nightly channel? Not tested

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? No

Miscellaneous Information:

Contributor guide

Research direction
Investigate how Brave applies themes to WebUI pages and fix the CSS for brave://apps to use the theme colors instead of a hardcoded gray.
Tech stack
javascriptcss
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
CSSBrave browser internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70