brave/brave-browser

Linux desktop file refers to "Incognito" windows

Open

#37,623 opened on Apr 16, 2024

View on GitHub
 (8 comments) (0 reactions) (0 assignees)JavaScript (2,164 forks)batch import
OS/DesktopOS/Linuxgood first issuepriority/P5

Repository metrics

Stars
 (16,194 stars)
PR merge metrics
 (Avg merge 4h 38m) (19 merged PRs in 30d)

Description

Description

Our brave-browser.deskop file, included with the official Linux packages, refers to brave --incognito as "New Incognito Window". This should use our "New Private Window" terminology.

Brave version (brave://version info)

1.64.122

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Miscellaneous Information:

Afaict gnome desktops don't use this information, but it's used by several of the older launchers.

Contributor guide

Research direction
Locate the brave browser.desktop file in the repository, find the line containing 'Incognito', and replace it with 'Private Window'.
Tech stack
None
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Linux desktop file basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90