brave/brave-browser

Commands in omnibox only show if Brave Search is default

Open

#38,793 opened on Jun 4, 2024

View on GitHub
 (1 comment) (0 reactions) (1 assignee)JavaScript (2,164 forks)batch import
OS/DesktopQA/Yesfeature/command-palettegood first issuepriority/P5release-notes/include

Repository metrics

Stars
 (16,194 stars)
PR merge metrics
 (Avg merge 4h 38m) (19 merged PRs in 30d)

Description

Description

If default search engine is google, commands don't show up

Steps to reproduce

  1. Set Google as browser's default search engine
  2. Open New Tab
  3. Type "new tab"

Actual result

Suggested browser commands don't show

Expected result

Suggested browser commands show as follows:

Reproduces how often

Easily reproduced

Brave version (brave://version info)

1.68.64

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

"Commands in omnibox" flag should be enabled (which is the default)

Contributor guide

Research direction
Investigate the condition that checks if Brave Search is the default search engine for showing commands in the omnibox. Look in the code that handles omnibox suggestions for the default provider check.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75