brave/brave-browser

Show BAT favicon when adding rewards internal page to sidebar

Open

#41,617 opened on Oct 14, 2024

View on GitHub
 (5 comments) (0 reactions) (1 assignee)JavaScript (2,164 forks)batch import
OS/Desktopfeature/settingsfeature/sidebargood first issuepriority/P5

Repository metrics

Stars
 (16,194 stars)
PR merge metrics
 (Avg merge 4h 38m) (19 merged PRs in 30d)

Description

When adding the rewards internal page to the sidebar, the icon doesn't appear and instead shows an "R". We should change the icon that shows so it shows the correct BAT icon

Figma https://www.figma.com/design/H11ZOl6JMYbCTW4ZJXqR5V/%F0%9F%A6%81-Browser?node-id=8165-19398&t=5wWBqB0CO1rtctLm-1

Actual result

Image

Expected result

Image

Contributor guide

Research direction
Locate the sidebar icon assets and replace the placeholder 'R' with the correct BAT icon. Refer to the Figma design for the exact icon.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70