brave/brave-browser

Right click (context menu) should have `Use Image as Desktop Picture`

Open

#7,922 opened on Jan 27, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (2,164 forks)batch import
OS/WindowsOS/macOSfeature-requestfeature/context-menufirefoxgood first issuehelp wantedpriority/P5

Repository metrics

Stars
 (16,194 stars)
PR merge metrics
 (Avg merge 4h 38m) (19 merged PRs in 30d)

Description

Description

macOS: When opening a context menu for an IMAGE on macOS (right click, ctrl + click, etc), there should be an option to Use Image as Desktop Picture (similar to Safari). ' under 'Save image as...'

Windows: When opening a context menu for an IMAGE on Windows, there should be an option to use 'Set as Desktop Background...' under 'Save image as...'

Steps to Reproduce

  1. Visit google.com and search for mercedes r129 red
  2. Click Images to show image search
  3. Right click any image

Actual result:

Expected result:

Contributor guide

Research direction
Examine the existing context menu implementation for images, particularly the 'Save image as...' item. Add menu items for 'Use Image as Desktop Picture' on macOS and 'Set as Desktop Background...' on Windows. For macOS, use the NSWorkspace method to set desktop picture. For Windows, use SystemParametersInfo with SPI SETDESKWALLPAPER. Ensure the implementation follows the existing patterns in the codebase.
Tech stack
javascript
Domain
desktop
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70