browsh-org/browsh

Kill the headless Firefox process by PID, not by grepping `ps`

Open

#61 opened on Jul 9, 2018

View on GitHub
 (2 comments) (3 reactions) (0 assignees)JavaScript (455 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (15,996 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

This was first brought up by a user that had an existing Selenium session: #59

If Browsh's Firefox process can have an identifying mark to it, then we can detect that instead of a crude detection of any headless Firefox process.

Contributor guide

Research direction
Inspect the code that launches Firefox and identify how to mark the process. Then update the process killing mechanism to use the PID of the marked process instead of grepping ps.
Tech stack
javascript
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitShell
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75