browsh-org/browsh

Fix bug in `webext/contrib/font_maker.py`

Open

#75 opened on Jul 10, 2018

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (455 forks)batch import
bughelp wanted

Repository metrics

Stars
 (15,996 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

See: https://milankragujevic.com/vip-drop-i-lekcije-u-odnosu-sa-korisnicima or any site with Chinese characters.

This site is the first non-Chinese site I've seen that is unable to hide the text during the graphics_builder screenshot phase.

Contributor guide

Research direction
Inspect the `webext/contrib/font maker.py` script to understand how Chinese characters are handled during the screenshot phase. Trace the rendering pipeline to see why the text is not being hidden.
Tech stack
javascriptpython
Domain
frontendcli
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
GitPython
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55