bumbu/svg-pan-zoom

Method for only disabling the click listener's preventDefault()

Open

#156 opened on Oct 13, 2015

View on GitHub
 (7 comments) (0 reactions) (0 assignees)JavaScript (383 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (1,585 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Thank you for #123.

But having the new option affect all events goes a little far for my use case. Now if I set preventMouseEventsDefault: false, I scroll the screen when trying to pan via touch or zoom with the mousewheel.

Is there a way to prevent this?

Contributor guide

Research direction
Look at the current event handling code, specifically how preventDefault is applied to mouse events. Introduce a new option like 'preventClickDefault' or modify the existing 'preventMouseEventsDefault' to allow selective disabling of click listener's preventDefault only.
Tech stack
javascript
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptSVG
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70