bumbu/svg-pan-zoom

beforeZoom doesn't work as expected

Open

#168 opened on Nov 25, 2015

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (383 forks)batch import
bughelp wanted

Repository metrics

Stars
 (1,585 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

See http://jsfiddle.net/jwasinger/1nojj7ru/2/

Steps to Reproduce Bug:

Desired Functionality: No zooming should occur.

Erroneous Behavior: Zoom occurs.

This has only been tested/observed on Chrome (46.0.2490.86) running on OSX (10.10.5) thus far.

Contributor guide

Research direction
Inspect the beforeZoom callback implementation to see why returning false does not prevent zoom. Trace the event handler path to verify the return value is checked.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75