bytedeco/javacv

The audioCodec parameter is not used or has no effect in FFmpegFrameGrabber

Open

#1,454 opened on Jun 20, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Java (1,583 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (6,985 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I set the audioCodec parameter in FFmpegFrameGrabber, but it has no effect. I then checked the source code and found that audioCodec was not used in FFmpegFrameGrabber. Is it in the 969 lines of code in FFmpegFrameGrabber:

AVCodec codec = avcodec_find_decoder_by_name(audioCodecName);
             if (codec == null) {
                 codec = avcodec_find_decoder(audio_par.codec_id());
             }

Whether the code should be modified or added:

If (codec == null) {
                 codec = avcodec_find_decoder(getAudioCodec());
    }

to make audioCodec effective? Thank you very much!

Contributor guide

Research direction
Verify the suggested code change in FFmpegFrameGrabber: inspect the audioCodec parameter usage and confirm that avcodec find decoder(getAudioCodec()) should be added as fallback.
Tech stack
java
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaFFmpeg concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70