bytedeco/javacv

is grabber's startUnsafe have any risk?

Open

#2,030 opened on May 24, 2023

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Java (1,583 forks)batch import
help wantedquestion

Repository metrics

Stars
 (6,985 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Hi, I met a problem when grab local video file and remote rtmp concurrent, when the rtmp is no stream, the rtmp's grabber's start method will block in the start method by rw_timeout，in this time, if local file 's grabber's start called, this call will block by the code in start method : synchronized (org.bytedeco.ffmpeg.global.avcodec.class)

So, I found the no synchronized version: startUnsafe and releaseUnsafe，I use them in the unstable rtmp situation and start/stop in local file, there is no problem found.

But, I worried about the "unsafe", Can you tell me is there some risk about the startunsafe/releaseUnsafe ? thank you!

Contributor guide

Research direction
Examine the JavaCV source code for startUnsafe and releaseUnsafe to understand thread safety implications. Check for necessary synchronization when using multiple grabbers concurrently.
Tech stack
java
Domain
backend
Issue type
Research
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Javaconcurrency
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70