bytedeco/javacv

do we need to call frame.close() after calling FFmpegFrameGrabber.grabImage() ?

Open

#2,175 opened on Jan 25, 2024

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Java (1,583 forks)batch import
help wantedquestion

Repository metrics

Stars
 (6,985 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

i try to get image per second from a video and i notice my java heap keep increasing and eventually causing OOM after processing more than 10 videos.

my sample code

try (FFmpegFrameGrabber frameGrabber = new FFmpegFrameGrabber(inputStream)) {
      frameGrabber.start();
      long lengthInSecond = frameGrabber.getLengthInTime() / NANO_SECONDS;
      for (int i = 0; i < lengthInSecond; i++) {
        frameGrabber.setVideoTimestamp(i * NANO_SECONDS);
        try (Frame frame = frameGrabber.grabImage()) {
          if (frame != null) {
            BufferedImage bufferedImage;
            try (Java2DFrameConverter converter = new Java2DFrameConverter()) {
              if ((bufferedImage = converter.convert(frame)) != null) {
                results.add(getColorHistogram(bufferedImage));
              }
            }
          }
        }
      }
      frameGrabber.stop();
    }

Contributor guide

Research direction
Investigate whether Frame objects returned by FFmpegFrameGrabber.grabImage() need to be closed manually to release native memory, and verify if the current try with resources usage is sufficient.
Tech stack
java
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaMemory Management
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60