callstack/react-native-paper

Input inside of Portal duplicates text

Open

#2,780 opened on Jun 18, 2021

View on GitHub
 (9 comments) (5 reactions) (1 assignee)TypeScript (2,005 forks)batch import
HacktoberfestKeep openedPortalhelp wantedrepro provided

Repository metrics

Stars
 (11,550 stars)
PR merge metrics
 (Avg merge 8d 12h) (10 merged PRs in 30d)

Description

Current behaviour

When a react-native TextInput is inside of a Portal (even if as a descendant, say, inside nested Views inside of a Modal ), when the user types, it will (inconsistently) duplicate the existing text in the input box

There doesn't seem to be a correlation between how much the user types. In my app (a non-minimal repro that I won't link), it seems to be nearly every 2-3 characters, but the minimal repro that I WILL link happens significantly more infrequently

I have only confirmed this behavior on Android, have not tested on iOS.

Expected behaviour

Text inputs in Portal should not duplicate text incorrectly

Code sample

https://github.com/crutchcorn/rn-paper-portal-bug-repro

Screenshots (if applicable)

keyboard-bug

What have you tried

  • Upgrading react-native
  • Upgrading react-native-paper
  • Creating minimal repro
  • Confirmed this happens on both emulator and physical device

Your Environment

software version
ios or android android v11
react-native 0.64.2
react-native-paper 4.9.1
node 12.16.1
npm or yarn yarn 1.22.5
expo sdk n/a

Contributor guide

Research direction
Investigate the Portal component's implementation in react native paper to understand how it handles children's state, especially for TextInput, and check for any re rendering issues that cause text duplication.
Tech stack
react nativetypescript
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
React Nativereact native paperTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60